[webkit-reviews] review denied: [Bug 14206] MSVC7 support and PLATFORM define fixes for Windows : [Attachment 16577] Patch with Adam Roben's changes

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has denied 's request for review:
Bug 14206: MSVC7 support and PLATFORM define fixes for Windows
http://bugs.webkit.org/show_bug.cgi?id=14206

Attachment 16577: Patch with Adam Roben's changes
http://bugs.webkit.org/attachment.cgi?id=16577&action=edit

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Thanks for taking a look at this! I think you're right that the debugger code
should be checking for the MSVC compiler. Whether or not the code can compile
in other environments (which I'm not sure about either), it's only useful when
you plan to use it with the Visual Studio IDE anyway, so I think it's best to
define it this way. As for vsnprintf, they weren't the same in previous
iterations which is why I had separate functions. I just didn't pay attention
to the fact that my recent changes made them the same. :-)