[webkit-reviews] review denied: [Bug 15378] WebKit GTK+ should use Font info from GtkStyle, and aliases, by default : [Attachment 16545] Updated with inline declarations

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 15378: WebKit GTK+ should use Font info from GtkStyle, and aliases, by
default
http://bugs.webkit.org/show_bug.cgi?id=15378

Attachment 16545: Updated with inline declarations
http://bugs.webkit.org/attachment.cgi?id=16545&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    int defsize =
pango_font_description_get_size(GTK_WIDGET(page)->style->font_desc);

Does GtkStyle store a separate default font size for fixed vs. variable width
fonts?

"defsize" should be renamed "defaultSize" to adhere to our coding style
guidelines <http://webkit.org/coding/coding-style.html>.

+	 defsize /= 1024;

Can we get this constant from a Pango header? If not, this constant should be a
static const int at the top of the file.

You'll need to add a ChangeLog entry before this can be landed. See
<http://webkit.org/coding/contributing.html> for instructions.