[webkit-reviews] review requested: [Bug 15299] GTK: ChromeClientGtk.cpp does not implement mouseDidMoveOverElement() : [Attachment 16569] Fix signal not emitted when hovering on links in succession - update

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 15299: GTK: ChromeClientGtk.cpp does not implement
mouseDidMoveOverElement()
http://bugs.webkit.org/show_bug.cgi?id=15299

Attachment 16569: Fix signal not emitted when hovering on links in succession -
update
http://bugs.webkit.org/attachment.cgi?id=16569&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> (In reply to comment #17)
> +    , m_hoveredLink(0)
> 
> KURL will be automatically initialized. So this is not needed/wanted. I
wonder
> what will happen in the following case:

Fixed in the updated patch.

> Currently you get a signal with NULL, NULL when leaving a link, when you
switch
> from one to another URL you will not get such a signal. Is that a semantic
> issue? Do we at least want to document this?

As long as we document it, it shouldn't be an issue. I thought the signal was
just a hint that we hovered out on a link. Any suggestions?

> I also wonder if we need
> m_didSendLinkSignal at all. We can just compare the URLs.

The updated patch removes m_didSendLinkSignal and just checks for differences
between current and previously hovered link.