[webkit-reviews] review denied: [Bug 15080] <use> element not refresh after adding objects by script in referrer : [Attachment 16550] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 5 14:42:21 PDT 2007


Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 15080: <use> element not refresh after adding objects by script in referrer
http://bugs.webkit.org/show_bug.cgi?id=15080

Attachment 16550: First attempt
http://bugs.webkit.org/attachment.cgi?id=16550&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    if (ownerDocument()->parsing())
+	 return;

Please use document(). ownerDocument() is just a slower way to call document()
that returns 0 in the special case of a Document node.

Why is it OK to skip updateElementInstance if parsing is true? What guarantees
it's called later?

review- for the ownerDocument thing and I'd also like to know the answer to my
question.



More information about the webkit-reviews mailing list