[webkit-reviews] review requested: [Bug 15359] JPEG image not shown when height is specified as percentage inside a table : [Attachment 16536] Hack v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 15359: JPEG image not shown when height is specified as percentage inside a
table
http://bugs.webkit.org/show_bug.cgi?id=15359

Attachment 16536: Hack v1
http://bugs.webkit.org/attachment.cgi?id=16536&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This is a hack that will allow the image to be display correctly within the
table (e.g., it displays the same as if the table were removed from the test). 
I'm setting the review flag to see if this is the correct approach.

Note that because of what isHeightSpecified() checks, this change in
RenderImage::calcReplacedHeight():

+    if (isHeightSpecified() && style()->height().type() != Percent)

could really just be:

+    if (style()->height().type() == Fixed)

If this is not the correct approach, then I'd guess that
RenderBox::calcReplacedHeightUsing() needs to be taught how to use
instrinsicSize() for <img> tags.  (Am I in the ballpark here? :)

Layout tests running now with this change to check for any failures.