[webkit-reviews] review granted: [Bug 13141] XMLHttpRequest should set readyState to 0 after abort() : [Attachment 16515] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 09:21:26 PDT 2007

Darin Adler <darin at apple.com> has granted Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 13141: XMLHttpRequest should set readyState to 0 after abort()

Attachment 16515: Updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
I think the change looks great.

+	 * ChangeLog:

The change log shouldn't be mentioned in the ChangeLog.

+	 * fast/dom/xmlhttprequest-html-response-encoding.html:
+	 Corrected a mal-formed test page

This doesn't quite match our change log format. Please look at other ChangeLog
entries. The overall concept of the change should be at the top, before the
list of files. What each file change contributes should be after the file
and/or function, without a blank space.

r=me for feature branch

More information about the webkit-reviews mailing list