[webkit-reviews] review requested: [Bug 6129] Incomplete implementation of CSS 2.1 system colors : [Attachment 16501] Possible patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 05:20:27 PDT 2007

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 6129: Incomplete implementation of CSS 2.1 system colors

Attachment 16501: Possible patch

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
This patch causes the colour of a button to change -- thus changing a lot of
layout test results.

Other than that, all we're doing is fetching the system colours from NSColor,
including a kind-of-nasty-but-only-way of getting pattern-based colours (which
we can't ask for the appropriate RGB components) by drawing a 1x1 square and
getting the colour of that pixel to determine the colour.

More information about the webkit-reviews mailing list