[webkit-reviews] review requested: [Bug 6129] Incomplete implementation of CSS 2.1 system colors : [Attachment 16501] Possible patch

[bugzilla-daemon at webkit.org]

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 6129: Incomplete implementation of CSS 2.1 system colors
http://bugs.webkit.org/show_bug.cgi?id=6129

Attachment 16501: Possible patch
http://bugs.webkit.org/attachment.cgi?id=16501&action=edit

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
This patch causes the colour of a button to change -- thus changing a lot of
layout test results.

Other than that, all we're doing is fetching the system colours from NSColor,
including a kind-of-nasty-but-only-way of getting pattern-based colours (which
we can't ask for the appropriate RGB components) by drawing a 1x1 square and
getting the colour of that pixel to determine the colour.