[webkit-reviews] review granted: [Bug 16207] JavaScript regular expressions should match UTF-16 code units rather than characters : [Attachment 17606] patch, speeds up SunSpider

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 16207: JavaScript regular expressions should match UTF-16 code units rather
than characters
http://bugs.webkit.org/show_bug.cgi?id=16207

Attachment 17606: patch, speeds up SunSpider
http://bugs.webkit.org/attachment.cgi?id=17606&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
 2425				      d = *++ptr;

The precedence here seems correct, but potentially confusing. Maybe *(++ptr)
would be better?

 757		     int c = *stack.currentFrame->args.subjectPtr++;

Again, parentheses might make it clearer what precedence you're expecting here
(and in the other instances of this expression).

 1640				      if (stack.currentFrame->args.subjectPtr
>= md.end_subject || isNewline(*stack.currentFrame->args.subjectPtr))

Why did you leave the comparison with md.end_subject here but now elsewhere?

r=me