[webkit-reviews] review requested: [Bug 13820] Height of cursor
should be same as height of text,
not line-height : [Attachment 17595] patch for fixing the cursor
height issue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 12:43:34 PST 2007
amit <amitjoshi_79 at yahoo.com> has asked for review:
Bug 13820: Height of cursor should be same as height of text, not line-height
http://bugs.webkit.org/show_bug.cgi?id=13820
Attachment 17595: patch for fixing the cursor height issue
http://bugs.webkit.org/attachment.cgi?id=17595&action=edit
------- Additional Comments from amit <amitjoshi_79 at yahoo.com>
It a simple patch that should fix the cursor height issue in the caretRect
method of RenderText. Also I had to override caretRect in
RenderTextControlInnerBlock to take care of the initial state of the cursor
(before first text char is entered).
This is my first attempt to hack webkit code- so please let me know if I am not
following the process correctly.
More information about the webkit-reviews
mailing list