[webkit-reviews] review requested: [Bug 16169] GIF ImageDecoder hasAlpha() return value incorrect : [Attachment 17577] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 11:26:48 PST 2007


Peter Kasting <zerodpx at gmail.com> has asked  for review:
Bug 16169: GIF ImageDecoder hasAlpha() return value incorrect
http://bugs.webkit.org/show_bug.cgi?id=16169

Attachment 17577: patch v1
http://bugs.webkit.org/attachment.cgi?id=17577&action=edit

------- Additional Comments from Peter Kasting <zerodpx at gmail.com>
Attempted fix (untested).

This was just oversight -- I meant to copy the alpha state from the previous
buffer at the same time I copied its bits.

The FIXME in ImageSourceCairo is based on IRC discussion with alp.


More information about the webkit-reviews mailing list