[webkit-reviews] review granted: [Bug 12216] Stack overflow crash in JavaScript garbage collector mark pass : [Attachment 17549] [2/6] JavaScriptCore:

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 12216: Stack overflow crash in JavaScript garbage collector mark pass
http://bugs.webkit.org/show_bug.cgi?id=12216

Attachment 17549: [2/6] JavaScriptCore:
http://bugs.webkit.org/attachment.cgi?id=17549&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Do we really need BooleanInstance::markChildren? Seems like it does no good and
just makes things a little slower.

 35	virtual void markChildren(MarkStack& stack);

I'd prefer to not name the argument in declarations like these.

I think the variable name "stack" is confusing in the context of the Collector
class, where we have something else called stackPointer and stackBase. Maybe in
some cases you should just use the name markStack.

r=me