[webkit-reviews] review granted: [Bug 16149] Implement the window-object-cleared signal : [Attachment 17540] Add support for this signal

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Alp Toker <alp at atoker.com>'s request
for review:
Bug 16149: Implement the window-object-cleared signal
http://bugs.webkit.org/show_bug.cgi?id=16149

Attachment 17540: Add support for this signal
http://bugs.webkit.org/attachment.cgi?id=17540&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    void (*window_object_cleared) (WebKitPage* page, WebKitFrame* frame,
JSContextRef context, JSObjectRef window_object);

window_object should be a JSGlobalContextRef (it's a mistake in the Windows
port that this is not the case).

+    // TODO: Re-attach debug clients if present.
+    // The Win port has an example of how we might do this.
+    //detachScriptDebugger();
+    //attachScriptDebugger();

We generally don't like to leave commented-out code in the source tree.

r=me