[webkit-reviews] review granted: [Bug 16149] Implement the window-object-cleared signal : [Attachment 17540] Add support for this signal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 26 17:40:04 PST 2007

Adam Roben <aroben at apple.com> has granted Alp Toker <alp at atoker.com>'s request
for review:
Bug 16149: Implement the window-object-cleared signal

Attachment 17540: Add support for this signal

------- Additional Comments from Adam Roben <aroben at apple.com>
+    void (*window_object_cleared) (WebKitPage* page, WebKitFrame* frame,
JSContextRef context, JSObjectRef window_object);

window_object should be a JSGlobalContextRef (it's a mistake in the Windows
port that this is not the case).

+    // TODO: Re-attach debug clients if present.
+    // The Win port has an example of how we might do this.
+    //detachScriptDebugger();
+    //attachScriptDebugger();

We generally don't like to leave commented-out code in the source tree.


More information about the webkit-reviews mailing list