[webkit-reviews] review granted: [Bug 16136] Use shared PixelDumpSupport for Mac DRT : [Attachment 17532] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 26 10:54:29 PST 2007

Adam Roben <aroben at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 16136: Use shared PixelDumpSupport for Mac DRT

Attachment 17532: patch

------- Additional Comments from Adam Roben <aroben at apple.com>
You might mention in the ChangeLog that you're now using ImageDiffCG as well.

+void drawWebViewIntoContext(CGContextRef);
+void repaintWithVerticalSweep(CGContextRef);
+void repaintWithHorizontalSweep(CGContextRef);
+void drawSelectionRectIntoContext(CGContextRef, CGRect);

How about:

void paintWebView(CGContextRef);
void repaintWebView(CGContextRef, bool horizontal);
void drawSelectionRect(CGContextRef, const CGRect&);


More information about the webkit-reviews mailing list