[webkit-reviews] review granted: [Bug 16137] Web Inspector window on Leopard should have a unified toolbar and window title : [Attachment 17526] Patch

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 16137: Web Inspector window on Leopard should have a unified toolbar and
window title
http://bugs.webkit.org/show_bug.cgi?id=16137

Attachment 17526: Patch
http://bugs.webkit.org/attachment.cgi?id=17526&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+#if PLATFORM(MAC)
+#ifdef BUILDING_ON_TIGER
+    String platform = "mac-tiger";
+#else
+    String platform = "mac-leopard";
+#endif
+#elif PLATFORM(WIN_OS)
+    String platform = "windows";
+#elif PLATFORM(QT)
+    String platform = "qt";
+#elif PLATFORM(GTK)
+    String platform = "gtk";
+#elif PLATFORM(WX)
+    String platform = "wx";
+#else
+    String platform = "unknown";
+#endif

You should make these static const Strings.

+    JSStringRef platformString =
JSStringCreateWithCharacters(platform.characters(), platform.length());

You should put this in a JSRetainPtr.

+	 Add a new class to make window corners square for textured windows.

Typo: class -> function

+void WKNSWindowSquareBottomCorners(NSWindow *);

It would be nice to get a verb in there somewhere (using "square" as a verb
isn't terribly clear). Maybe WKNSWindowMakeBottomCornersSquare?

r=me