[webkit-reviews] review granted: [Bug 16133] Implement pixel test support on Windows : [Attachment 17520] [5/5] Fix Bug 16133: Implement pixel test support on Windows

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Adam Roben <aroben at apple.com>'s request
for review:
Bug 16133: Implement pixel test support on Windows
http://bugs.webkit.org/show_bug.cgi?id=16133

Attachment 17520: [5/5] Fix Bug 16133: Implement pixel test support on Windows
http://bugs.webkit.org/attachment.cgi?id=17520&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
I can't image that forwarding the main function is helpful.
+/* prototypes */
+int main(int argc, const char* argv[]);

Please use c++ style casts here.
+    percentage = (float)((int)(percentage * 100.0f)) / 100.0f; // round to 2
decimal places

Please use ASSERT.
+    assert(!(bitmapInfo & kCGImageAlphaFirst));
+    assert(!(bitmapInfo & kCGBitmapFloatComponents));


r=me