[webkit-reviews] review requested: [Bug 16133] Implement pixel test
support on Windows : [Attachment 17518] [3/5] Implement pixel
dumping in Windows DRT
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 25 14:26:30 PST 2007
Adam Roben <aroben at apple.com> has asked for review:
Bug 16133: Implement pixel test support on Windows
http://bugs.webkit.org/show_bug.cgi?id=16133
Attachment 17518: [3/5] Implement pixel dumping in Windows DRT
http://bugs.webkit.org/attachment.cgi?id=17518&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
Part of http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>
Reviewed by NOBODY (OOPS!).
* DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
(printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
Content-Length header.
(getMD5HashStringForBitmap):
(dumpWebViewAsPixelsAndCompareWithExpected):
* DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from
WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
* DumpRenderTree/win/DumpRenderTree.cpp:
(dump): Do a pixel dump if requested.
(main): Parse pixel test options.
* DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
the cg/ subdirectory to the include path.
* DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
available in a header or import library, so we have to go through this
LoadLibrary/GetProcAddress dance to use them.
(cryptDLL):
(init):
(update):
(final):
(MD5_Init):
(MD5_Update):
(MD5_Final):
* DumpRenderTree/win/MD5.h: Added.
* DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
moved up to the top level to share it with Mac eventually.
* DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
(getBitmapContextFromWebView): Forces the WebView to paint using a
WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
---
WebKitTools/ChangeLog | 37 +++++++
.../DumpRenderTree/cg/PixelDumpSupportCG.cpp | 105 ++++++++++++++++++++
WebKitTools/DumpRenderTree/cg/PixelDumpSupportCG.h | 41 ++++++++
WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp | 21 ++++
.../DumpRenderTree/win/DumpRenderTree.vcproj | 34 ++++++-
WebKitTools/DumpRenderTree/win/MD5.cpp | 77 ++++++++++++++
WebKitTools/DumpRenderTree/win/MD5.h | 45 +++++++++
WebKitTools/DumpRenderTree/win/PixelDumpSupport.h | 36 +++++++
.../DumpRenderTree/win/PixelDumpSupportWin.cpp | 67 +++++++++++++
9 files changed, 458 insertions(+), 5 deletions(-)
More information about the webkit-reviews
mailing list