[webkit-reviews] review requested: [Bug 16104] [GTK] There is no way to retrieve the frame source : [Attachment 17508] Implement webkit_frame_copy_source

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 25 08:54:53 PST 2007


Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 16104: [GTK] There is no way to retrieve the frame source
http://bugs.webkit.org/show_bug.cgi?id=16104

Attachment 17508: Implement webkit_frame_copy_source
http://bugs.webkit.org/attachment.cgi?id=17508&action=edit

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
I changed the name to avoid some confusion.

As _copy suggests the function now allocates a new string because we don't know
how long the buffer is valid. And caching behind the scenes doesn't seem to be
a good idea here.


More information about the webkit-reviews mailing list