[webkit-reviews] review granted: [Bug 15564] HitTesting is incorrect for test-anchor: middle : [Attachment 17503] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 25 04:08:08 PST 2007

Adam Roben <aroben at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 15564: HitTesting is incorrect for test-anchor: middle

Attachment 17503: Initial patch

------- Additional Comments from Adam Roben <aroben at apple.com>
+		     it++;

We normally use the prefix increment operator on iterators, for efficiency.

+    if (pathData)
+	 return pathData->hidden;
+    return false;

This can just be

return pathData && pathData->hidden;

Make sure you land the layout test and results with it.


More information about the webkit-reviews mailing list