[webkit-reviews] review denied: [Bug 16128] ignore resizable=no for window.open() : [Attachment 17502] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 25 00:52:18 PST 2007

Adam Roben <aroben at apple.com> has denied rahul abrol <ra5ul at comcast.net>'s
request for review:
Bug 16128: ignore resizable=no for window.open()

Attachment 17502: patch v1

------- Additional Comments from Adam Roben <aroben at apple.com>
+    // Ignore resizable key
+    //    else if (keyString == "resizable")
+    //        windowFeatures.resizable = value;

We don't like to leave commented-out code in our source tree. Having a comment
about ignoring resizable is good (perhaps at the start of this if/else chain),
but the code should just be removed.

+    // Default to true
+    windowFeatures.resizable = true;

This comment should be omitted, as it add any information to the code below it.

Should we just remove windowFeatures.resizable entirely?

r- so the above issues can be fixed.

More information about the webkit-reviews mailing list