[webkit-reviews] review denied: [Bug 16124] Add printf format
attribute to several functions to fix some GCC warnings :
[Attachment 17497] Revised patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 24 20:54:52 PST 2007
Mark Rowe (bdash) <mrowe at apple.com> has denied Laszlo Gombos
<laszlo.gombos at gmail.com>'s request for review:
Bug 16124: Add printf format attribute to several functions to fix some GCC
warnings
http://bugs.webkit.org/show_bug.cgi?id=16124
Attachment 17497: Revised patch
http://bugs.webkit.org/attachment.cgi?id=17497&action=edit
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The attributes on warningHandler, fatalErrorHandler and friends should probably
go on the functions themselves rather than forward-declaring them such as you
have.
Why does handleError need the attribute? It does not appear to be used with a
format string.
More information about the webkit-reviews
mailing list