[webkit-reviews] review denied: [Bug 9683] Implement select.options.remove() method : [Attachment 17490] Implement select.options.remove() method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 24 19:22:50 PST 2007

Maciej Stachowiak <mjs at apple.com> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 9683: Implement select.options.remove() method

Attachment 17490: Implement select.options.remove() method

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I think this has a potential bug. If you retrieve select.options on a select,
then remove it from the document and let a GC happen, this line will crash
because the wrapper will already have been GC'd:

+    JSHTMLSelectElement* base = static_cast<JSHTMLSelectElement*>(toJS(exec,

Please add a test case along those lines and if it indeed causes a crash where
I expect please fix patch appropriately (you may have to duplicate the custom
logic from HTMLSelectElement.

More information about the webkit-reviews mailing list