[webkit-reviews] review denied: [Bug 16124] Add printf format attribute to several functions to fix some GCC warnings : [Attachment 17493] Fix attached.

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Laszlo Gombos
<laszlo.gombos at gmail.com>'s request for review:
Bug 16124: Add printf format attribute to several functions to fix some GCC
warnings
http://bugs.webkit.org/show_bug.cgi?id=16124

Attachment 17493: Fix attached.
http://bugs.webkit.org/attachment.cgi?id=17493&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Substance of the change looks good. A few comments on style:

1) We usually use #if COMPILER(GCC) rather than #if __GNUC__

2) It might be a good idea to make a macro that's defined to either the right
attribtue or nothing depending on the compiler, to avoid sprinking the code
with compiler #ifdefs.

Please make those adjustments (feel free to also fix existing uses of the
printf attribute).

r- for now, will gladly re-review with those fixes.