[webkit-reviews] review granted: [Bug 16121] Web Inspector needs
helper functions that pass a 'this' object to
addEventListener and setTimeout : [Attachment 17488] Revised Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 24 14:34:20 PST 2007
Adam Roben <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 16121: Web Inspector needs helper functions that pass a 'this' object to
addEventListener and setTimeout
http://bugs.webkit.org/show_bug.cgi?id=16121
Attachment 17488: Revised Patch
http://bugs.webkit.org/attachment.cgi?id=17488&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
I think "toggleExpanded" would be clearer than just "toggle" for the two places
you added that function.
I don't think the order of the <script> elements matters, since none of this
code gets executed as it's parsed.
r=me
More information about the webkit-reviews
mailing list