[webkit-reviews] review requested: [Bug 15938] Inspector/Qt requires patch to SecurityOrigin : [Attachment 17483] ASCII Trie with wasting memory for faster lookup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 24 04:29:15 PST 2007


Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 15938: Inspector/Qt requires patch to SecurityOrigin
http://bugs.webkit.org/show_bug.cgi?id=15938

Attachment 17483: ASCII Trie with wasting memory for faster lookup
http://bugs.webkit.org/attachment.cgi?id=17483&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
- Security: I changed both occurences of "file" in SecuritOrigin to use
FrameLoader::shouldTreatSchemeAsLocal

- Implement looking up the scheme using a Trie. As of the URI RFC the scheme
must be alpha and this is why I can use a fixed size array for lookup.

- No idea how the ASCIIType usage impacts the performance. Comments are
welcome.


More information about the webkit-reviews mailing list