[webkit-reviews] review denied: [Bug 15715] Nested XSL stylesheets can produce memory corruption : [Attachment 16995] proposed patch, fixed indentation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 23 20:49:41 PST 2007

Alexey Proskuryakov <ap at webkit.org> has denied Jonathan Haas
<myrdred at gmail.com>'s request for review:
Bug 15715: Nested XSL stylesheets can produce memory corruption

Attachment 16995: proposed patch, fixed indentation

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
(In reply to comment #9)
> > Can we use xmlCtxtReadMemory()?
> No, because libxml2 doesn't expose xmlCreateMemoryParserContext().

Looks like the context for xmlCtxtReadMemory() is to be created with
xmlNewParserCtxt(), which is exposed.

r-, because we want to avoid reconversion to UTF-8.  Sorry for slow reviewing -
I'm trying to get more familiar with XSLT ownership issues now!

More information about the webkit-reviews mailing list