[webkit-reviews] review denied: [Bug 15561] GTK port needs DumpRenderTree implementation : [Attachment 17456] WebKitFrame changes needed to support DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 23 01:22:14 PST 2007


Maciej Stachowiak <mjs at apple.com> has denied Alp Toker <alp at atoker.com>'s
request for review:
Bug 15561: GTK port needs DumpRenderTree implementation
http://bugs.webkit.org/show_bug.cgi?id=15561

Attachment 17456: WebKitFrame changes needed to support DRT
http://bugs.webkit.org/attachment.cgi?id=17456&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'm ok with contributing to this file under LGPL assuming other WebKit/Gtk
hackers are ok with this direction. However, I don't think you can just delete
the BSD-style license. I think you need to preserve the notice, although of
course the LGPL will take precedence.

The code changes look ok to me but I think I should r- over the license detail.
Please fix and resubmit.


More information about the webkit-reviews mailing list