[webkit-reviews] review denied: [Bug 15961] View source mode is missing the processing instruction line. : [Attachment 17217] Preliminary patch for discussion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 22 23:00:45 PST 2007


Maciej Stachowiak <mjs at apple.com> has denied Anyang Ren
<anyang.ren at gmail.com>'s request for review:
Bug 15961: View source mode is missing the processing instruction line.
http://bugs.webkit.org/show_bug.cgi?id=15961

Attachment 17217: Preliminary patch for discussion
http://bugs.webkit.org/attachment.cgi?id=17217&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'm not 100% sure if this change is right, it seems generally ok.

However, it needs a ChangeLog and a layout test. You can force view source mode
by putting the relevant contents into an <iframe> element with the viewsource
attribute set.

r- for lack of test case and ChangeLog.


More information about the webkit-reviews mailing list