[webkit-reviews] review granted: [Bug 16071] Curl backend handles
EINTR incorrectly : [Attachment 17431] Defer timers during select()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 21 18:58:05 PST 2007
Mark Rowe (bdash) <mrowe at apple.com> has granted Alp Toker <alp at atoker.com>'s
request for review:
Bug 16071: Curl backend handles EINTR incorrectly
http://bugs.webkit.org/show_bug.cgi?id=16071
Attachment 17431: Defer timers during select()
http://bugs.webkit.org/attachment.cgi?id=17431&action=edit
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
r=me, though I think the while should be written as while (condition) { } if
you're going to squish it all on one line. It's too easy to overlook the
semicolon, and some versions of GCC like to emit warnings for code like this.
More information about the webkit-reviews
mailing list