[webkit-reviews] review denied: [Bug 15984] Implement
"navigation-requested" signal for WebKit Gtk : [Attachment
17432] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 21 18:41:24 PST 2007
Alp Toker <alp at atoker.com> has denied Michael Natterer <mitch at imendio.com>'s
request for review:
Bug 15984: Implement "navigation-requested" signal for WebKit Gtk
http://bugs.webkit.org/show_bug.cgi?id=15984
Attachment 17432: updated patch
http://bugs.webkit.org/attachment.cgi?id=17432&action=edit
------- Additional Comments from Alp Toker <alp at atoker.com>
Please update the enum name and order of the element names as we discussed.
I tried to apply this patch and it does not compile. Can you test against a
non-git checkout to make sure the next revision applies cleanly and builds?
Also, could you use the closest available ChangeLog file rather than the root
ChangeLog?
Thanks!
More information about the webkit-reviews
mailing list