[webkit-reviews] review granted: [Bug 16087] Clean up more DRT code
: [Attachment 17437] [PATCH] More refactoring for greater
code readability
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 21 17:45:31 PST 2007
Adam Roben <aroben at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 16087: Clean up more DRT code
http://bugs.webkit.org/show_bug.cgi?id=16087
Attachment 17437: [PATCH] More refactoring for greater code readability
http://bugs.webkit.org/attachment.cgi?id=17437&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
Your setup* methods should really be setUp*, since you're using the verb "to
set up", not the noun "setup".
r=me, assuming the tests still pass :-)
More information about the webkit-reviews
mailing list