[webkit-reviews] review requested: [Bug 15530] XMLHttpRequest
should not support certain methods : [Attachment 17430] Patch
updated with Ap's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 21 07:55:42 PST 2007
Julien Chaffraix <julien.chaffraix at gmail.com> has asked for review:
Bug 15530: XMLHttpRequest should not support certain methods
http://bugs.webkit.org/show_bug.cgi?id=15530
Attachment 17430: Patch updated with Ap's comments
http://bugs.webkit.org/attachment.cgi?id=17430&action=edit
------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
> (From update of attachment 17429 [edit])
> + layoutTestController.waitUntilDone();
> This is not needed.
Removed.
> + try {
> + xhr.open(method, "resources/1251.html", true);
> + xhr.send(null);
> This test doesn't differentiate between open() and send() raising an
> exception,
> I think it should.
In fact, the exception should be raised only for open() so I removed send() as
it was not relevant.
> It may be slightly better to use sync XHR in the test, to maqke it more
> explicit that we don't wait for anything to finish.
The new test case uses a sync XHR.
More information about the webkit-reviews
mailing list