[webkit-reviews] review granted: [Bug 16056] Unicode not being interpreted correctly in Web Inspector source view : [Attachment 17420] proposed fix

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 16056: Unicode not being interpreted correctly in Web Inspector source view
http://bugs.webkit.org/show_bug.cgi?id=16056

Attachment 17420: proposed fix
http://bugs.webkit.org/attachment.cgi?id=17420&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    if (resource->requestURL == resource->loader->requestURL()) {
	 buffer = resource->loader->mainResourceData();
-    else {
+	 textEncodingName =
resource->loader->frame()->document()->inputEncoding();
+    } else {

Don't need braces here

+	 virtual String encoding() const;

Can these methods return a const String&? Or are they returning transient
Strings?

r=me