[webkit-reviews] review granted: [Bug 16036] Further cleanup to PCRE : [Attachment 17391] [PATCH] Pull first_byte and req_byte optimizations out into separate static funtions, SunSpider reported this as a win.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 16036: Further cleanup to PCRE
http://bugs.webkit.org/show_bug.cgi?id=16036

Attachment 17391: [PATCH] Pull first_byte and req_byte optimizations out into
separate static funtions, SunSpider reported this as a win.
http://bugs.webkit.org/attachment.cgi?id=17391&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
There are a few style issues in tryFirstByteOptimization:

Brace after if.
+	 if (first_byte_caseless)
+	     while (subjectPtr < endSubject) {

braces after the else
+	 else
+	     while (subjectPtr < endSubject && *subjectPtr != first_char)
+		 subjectPtr++;


Else on the same line as the brace.
+    }
+    /* Or to just after \n for a multiline match if possible */
+    else if (useMultiLineFirstCharOptimization) {

r=me