[webkit-reviews] review granted: [Bug 16036] Further cleanup to PCRE : [Attachment 17378] [PATCH] Small speedup (0.7%) by simplifying canUseStackBufferForNextFrame() check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 13:45:46 PST 2007


Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 16036: Further cleanup to PCRE
http://bugs.webkit.org/show_bug.cgi?id=16036

Attachment 17378: [PATCH] Small speedup (0.7%) by simplifying
canUseStackBufferForNextFrame() check
http://bugs.webkit.org/attachment.cgi?id=17378&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
This looks good but I think you can use a static const instead of the #define
+#define FRAMES_ON_STACK 16

r=me otherwise.


More information about the webkit-reviews mailing list