[webkit-reviews] review granted: [Bug 16074] execCommand("InsertHorizontalRule", false, "") results in id="" being inserted : [Attachment 17419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 13:20:33 PST 2007


Sam Weinig <sam at webkit.org> has granted Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 16074: execCommand("InsertHorizontalRule", false, "") results in id=""
being inserted
http://bugs.webkit.org/show_bug.cgi?id=16074

Attachment 17419: Patch
http://bugs.webkit.org/attachment.cgi?id=17419&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
I think a test of InsertOrderedList and InsertUnorderedList with an empty
string 3rd parameter would be nice if it doesn't already exist. 

r=me.


More information about the webkit-reviews mailing list