[webkit-reviews] review granted: [Bug 16053] prepend git branch with build-webkit and friends : [Attachment 17413] prepend git branch V2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 09:31:43 PST 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Treat
<treat at kde.org>'s request for review:
Bug 16053: prepend git branch with build-webkit and friends

Attachment 17413: prepend git branch V2

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>+    unless (defined $gitBranch) {
>+	  chomp($gitBranch = `git symbolic-ref -q HEAD`);
>+	  $gitBranch =~ s#^refs/heads/##;
>+	  $gitBranch = "" if $gitBranch eq "master";
>+	  $gitBranch = "" if exitStatus($?);
>+    }

I think it would make more sense to check the exit status immediately after the
command is run.


Do you have a preference between "webkitbranchbuild" or "webKitBranchBuild" (or
"webkitBranchBuild")?  I see both all-lowercase and camelCase config options in
"man git-config", but I think it's much easier to read the camelCase version.

r=me, although I'd like to see the above changes made when committing.

More information about the webkit-reviews mailing list