[webkit-reviews] review denied: [Bug 16052] prepare-ChangeLog doesn't report deleted files : [Attachment 17402] Patch to get prepare-ChangeLog to report deleted files

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 16052: prepare-ChangeLog doesn't report deleted files
http://bugs.webkit.org/show_bug.cgi?id=16052

Attachment 17402: Patch to get prepare-ChangeLog to report deleted files
http://bugs.webkit.org/attachment.cgi?id=17402&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Marking r- since this is the wrong fix.

The prepare-ChangeLog script already reports removed files for svn.

I just realized that the actual bug is that prepare-ChangeLog ignores changes
staged to the index for git.  For example, if you use "git rm path/to/file"
instead of "rm path/to/file", the prepare-ChangeLog script ignores this change
since it doesn't use the --cached switch on git-diff.

Also, if you git-add changed files before running prepare-ChangeLog, those
changes won't be seen, either.

Should we be running git-diff with and without "--cached", or should we be
looking at the output of git-status and parsing both of its sections?

Kevin, are you using svn or git?  Does the above explain the issue you're
seeing?