[webkit-reviews] review denied: [Bug 15669] Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port : [Attachment 17403] Put a license block in the new header and update the description about npapi/npruntime

[bugzilla-daemon at webkit.org]

Alp Toker <alp at atoker.com> has denied Rodney Dawes <dobey at wayofthemonkey.com>'s
request for review:
Bug 15669: Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port
http://bugs.webkit.org/show_bug.cgi?id=15669

Attachment 17403: Put a license block in the new header and update the
description about npapi/npruntime
http://bugs.webkit.org/attachment.cgi?id=17403&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
>Index: WebCore/WebCore.pro
>===================================================================
>--- WebCore/WebCore.pro	(revision 27906)
>+++ WebCore/WebCore.pro	(working copy)
>@@ -91,6 +91,11 @@ DEPENDPATH += editing/qt history/qt load
> }
> 
> gtk-port {
>+!mac:!win32-* {
>+    DEFINES += XP_UNIX
>+    LIBS += -lXt
>+}

The assumption that !mac:!win32-* implies that X11 is available is incorrect.
The core of the GTK+ port is windowing-system neutral, so features specific to
X11 need to be added with care.

I'm also not convinced that we want to link to Xt by default even when X11 is
available. Can we make plugin support an optional feature?

Thanks.