[webkit-reviews] review denied: [Bug 15669] Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port : [Attachment 17400] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 10:45:08 PST 2007

Alp Toker <alp at atoker.com> has denied Rodney Dawes <dobey at wayofthemonkey.com>'s
request for review:
Bug 15669: Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port

Attachment 17400: Updated patch

------- Additional Comments from Alp Toker <alp at atoker.com>
Looks like this patch will break non-X11 builds like DirectFB. There needs to
be a configure switch to mark that X11 is available or something.

Also, linking to Xt doesn't sound like the right thing to do in standard
WebKit/GTK+ builds. There should be an optional switch to enable this kind of

More information about the webkit-reviews mailing list