[webkit-reviews] review denied: [Bug 15940] Implement threading API for Qt : [Attachment 17180] Implements threading for Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 07:58:31 PST 2007

Mark Rowe (bdash) <mrowe at apple.com> has denied Justin Haygood
<jhaygood at reaktix.com>'s request for review:
Bug 15940: Implement threading API for Qt

Attachment 17180: Implements threading for Qt

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Overall this looks reasonable to me, but there are a bunch of coding style

In a few places you have extra whitespace inside function calls, such as:

key( thread, 0 );

Constructors should initialize their members via the initialization list rather
than via assignment in their body.

You've used tabs for indentation in some places.

Methods in ThreadPrivate use "this->" when accessing their member variables. 
The members should also have an m_ prefix.

More information about the webkit-reviews mailing list