[webkit-reviews] review granted: [Bug 16036] Further cleanup to PCRE : [Attachment 17350] [PATCH] clean up check_escape

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 18 19:45:15 PST 2007


Sam Weinig <sam at webkit.org> has granted 's request for review:
Bug 16036: Further cleanup to PCRE
http://bugs.webkit.org/show_bug.cgi?id=16036

Attachment 17350: [PATCH] clean up check_escape
http://bugs.webkit.org/attachment.cgi?id=17350&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
I am not a fan of multiple case statements on a line but I don't think we have
a rule about this.
+	 case '1': case '2': case '3': case '4': case '5':
+	 case '6': case '7': case '8': case '9':

r=me.


More information about the webkit-reviews mailing list