[webkit-reviews] review granted: [Bug 16036] Further cleanup to PCRE : [Attachment 17338] [PATCH] Get rid of PCRE custom char types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 18 19:10:11 PST 2007

Sam Weinig <sam at webkit.org> has granted 's request for review:
Bug 16036: Further cleanup to PCRE

Attachment 17338: [PATCH] Get rid of PCRE custom char types

------- Additional Comments from Sam Weinig <sam at webkit.org>
The typedef for USPTR was const UChar* but you seem to be using a non-const
version in most places you replaced it.  What was the motivation behind that
change.  Otherwise, r=me with a ChangeLog.

More information about the webkit-reviews mailing list