[webkit-reviews] review granted: [Bug 16036] Further cleanup to
PCRE : [Attachment 17356] [PATCH] cleanup _pcre_ucp_othercase
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 18 15:14:04 PST 2007
Sam Weinig <sam at webkit.org> has granted 's request for review:
Bug 16036: Further cleanup to PCRE
http://bugs.webkit.org/show_bug.cgi?id=16036
Attachment 17356: [PATCH] cleanup _pcre_ucp_othercase
http://bugs.webkit.org/attachment.cgi?id=17356&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
In the other patches I have reviewed so far you are changing infinite loops
like
+ for (;;) {
to while (true). I think it is better to be consistent and change this one as
well.
r=me with ChangeLog.
More information about the webkit-reviews
mailing list