[webkit-reviews] review denied: [Bug 15938] Inspector/Qt requires patch to SecurityOrigin : [Attachment 17243] Add FrameLoader::shouldTreatSchemeAsLocal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 17 15:35:59 PST 2007

Darin Adler <darin at apple.com> has denied Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 15938: Inspector/Qt requires patch to SecurityOrigin

Attachment 17243: Add FrameLoader::shouldTreatSchemeAsLocal

------- Additional Comments from Darin Adler <darin at apple.com>
The additional string allocation from calling left() on the URL string will
almost certainly cause an unacceptable slowdown; there's a reason we added
those special cases for "http" and "file" to avoid memory allocation.

The concept of the patch is fine, but we need a more efficient version.

More information about the webkit-reviews mailing list