[webkit-reviews] review denied: [Bug 16024] prepare-Changelog needs to use git repo-config if git config fails : [Attachment 17326] Try git config, then git repo-config if the first fails

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Ryan Leavengood
<leavengood at gmail.com>'s request for review:
Bug 16024: prepare-Changelog needs to use git repo-config if git config fails
http://bugs.webkit.org/show_bug.cgi?id=16024

Attachment 17326: Try git config, then git repo-config if the first fails
http://bugs.webkit.org/attachment.cgi?id=17326&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>     my $result = `$GIT config $config`;
>+		 if ($result =~ /is not a git-command/) {
>+				 $result = `$GIT repo-config $config`;
>+		 }

I think it would be best to check the exit value of the backtick command
instead of the error text:

if (($? >> 8) != 0) {

Also, please use the same indention rules as the rest of the script.

Please make these changes and repost.  Thanks!