[webkit-reviews] review granted: [Bug 15682] Move wx port to TOT : [Attachment 17218] wxWebKit build script, sample app, and impl of build-webkit --clean

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 16 20:20:45 PST 2007


Darin Adler <darin at apple.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 15682: Move wx port to TOT
http://bugs.webkit.org/show_bug.cgi?id=15682

Attachment 17218: wxWebKit build script, sample app, and impl of build-webkit
--clean
http://bugs.webkit.org/attachment.cgi?id=17218&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+if ($clean) {
+    exit 0;
+}

Things like this read better in perl as:

    exit if $clean;

I'm really disappointed to see build-wxwebkit as an entirely separate script
with so much code in it!

r=me


More information about the webkit-reviews mailing list