[webkit-reviews] review granted: [Bug 12194] Trying to access XMLHttpRequest.responseText or responseXML when they are not available should raise an exception : [Attachment 17309] Patch + test cases

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when
they are not available should raise an exception
http://bugs.webkit.org/show_bug.cgi?id=12194

Attachment 17309: Patch + test cases
http://bugs.webkit.org/attachment.cgi?id=17309&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	     if (responseXML)
		 return toJS(exec, responseXML);
-	     return jsNull();
+	     else
+		 return jsNull();

We normally do *not* do else after return in the WebKit project.

+    if (m_state < Receiving) {
+	 ec = INVALID_STATE_ERR;
+    }

We do not put braces around single-line bodies of if statements.

+Should see "PASS" four times:
+
+PASSED
+PASSED
+PASSED
+PASSED

Probably should say "PASSED" or "PASS" consistently.

Change looks good, so I'll say r=me, but it would be nice to fix these minor
style issues.