[webkit-reviews] review requested: [Bug 15974] Public GIF image decoder does not handle disposal of previous frames correctly : [Attachment 17320] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 16 14:18:35 PST 2007


Peter Kasting <zerodpx at gmail.com> has asked  for review:
Bug 15974: Public GIF image decoder does not handle disposal of previous frames
correctly
http://bugs.webkit.org/show_bug.cgi?id=15974

Attachment 17320: patch v1
http://bugs.webkit.org/attachment.cgi?id=17320&action=edit

------- Additional Comments from Peter Kasting <zerodpx at gmail.com>
This patch makes all the above attached images work correctly.	It also calls
ensureHeight() in a more consistent way (we don't ensureHeight(m_size.height())
on some frames before decoding anything the way we did before) and calls
setHasAlpha() correctly (although a bit conservatively -- we might claim to
have alpha when we don't, but never the other way), which was trickier with the
new initialization code.


More information about the webkit-reviews mailing list