[webkit-reviews] review denied: [Bug 15669] Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port : [Attachment 17315] Updated patch with most of the undefs in npapi.h

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 15669: Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port
http://bugs.webkit.org/show_bug.cgi?id=15669

Attachment 17315: Updated patch with most of the undefs in npapi.h
http://bugs.webkit.org/attachment.cgi?id=17315&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
It turns out that npapi.h is a public API header file so we can't do the
#undef's there.  What we'll need to do is add a new header file to
JavaScriptCore that includes npapi.h and Xresources.h and then #undef's the
relevant values.  Places inside JavaScriptCore/WebCore/WebKit that include
npapi.h should then be updated to include that wrapper header file instead.

One issue is that npruntime.h, another public API header file, includes npapi.h
and we clearly can't include our wrapper header in that.  It may be required to
wrap npruntime.h instead of npapi.h and move anyone that includes npapi.h or
npruntime.h directly to the wrapper.