[webkit-reviews] review requested: [Bug 14809] [gtk] Implement settings as properties of WebKitGtkPage : [Attachment 17308] Correct script prompt return value and avoid warrings.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 18:35:24 PST 2007


Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 14809: [gtk] Implement settings as properties of WebKitGtkPage
http://bugs.webkit.org/show_bug.cgi?id=14809

Attachment 17308: Correct script prompt return value and avoid warrings.
http://bugs.webkit.org/attachment.cgi?id=17308&action=edit

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
This changes the behavior of the script-prompt to return NULL when the dialog
is cancelled. This matches other browsers, tested with Firefox and Opera on a
number of websites.

Besides I changed a bit of the dialog code to avoid compiler warnings regarding
uninitialized values.

At last I modifed the console message default to prevent linkification in
terminals to include the line number in the link.


More information about the webkit-reviews mailing list